Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: precompute field names #1772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src: precompute field names #1772

wants to merge 1 commit into from

Commits on Mar 25, 2024

  1. src: precompute field names 

    Field names do not change from row to row, so let's create JS strings
only during the process of calling back into JS with the first row, not
with each row. We save the JS strings we created while calling back
with the first row, and re-use them when creating objects for
subsequent rows.

Re: nodejs/abi-stable-node#458
    @gabrielschulhof
    gabrielschulhof committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ff709c4 View commit details
    Browse the repository at this point in the history