Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated arm64 builds to native machines #1742

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Migrated arm64 builds to native machines #1742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04c1fb
Removed Node version from matrix title
daniellockyer Dec 30, 2023
9233494
Moved Linux ARM64 compilation to native builder
daniellockyer Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ jobs:
node:
- 18
include:
- os: ubuntu-20.04
node: 18
host: x64
target: arm64
- os: windows-latest
node: 18
host: x86
Expand All @@ -37,7 +41,7 @@ jobs:
node: 18
host: arm64
target: arm64
name: ${{ matrix.os }} (node=${{ matrix.node }}, host=${{ matrix.host }}, target=${{ matrix.target }})
name: ${{ matrix.os }} (host=${{ matrix.host }}, target=${{ matrix.target }})
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
Expand Down Expand Up @@ -82,19 +86,38 @@ jobs:
echo "CFLAGS=${CFLAGS:-} -include ../src/gcc-preinclude.h" >> $GITHUB_ENV
echo "CXXFLAGS=${CXXFLAGS:-} -include ../src/gcc-preinclude.h" >> $GITHUB_ENV

- name: Setup cross compilation for Linux ARM64
if: contains(matrix.os, 'ubuntu') && matrix.target == 'arm64'
run: |
sudo apt-get install -y gcc-aarch64-linux-gnu g++-aarch64-linux-gnu binutils-aarch64-linux-gnu
echo "AS=aarch64-linux-gnu-as" >> $GITHUB_ENV
echo "STRIP=aarch64-linux-gnu-strip" >> $GITHUB_ENV
echo "AR=aarch64-linux-gnu-ar" >> $GITHUB_ENV
echo "CC=aarch64-linux-gnu-gcc" >> $GITHUB_ENV
echo "CPP=aarch64-linux-gnu-cpp" >> $GITHUB_ENV
echo "CXX=aarch64-linux-gnu-g++" >> $GITHUB_ENV
echo "LD=aarch64-linux-gnu-ld" >> $GITHUB_ENV
echo "FC=aarch64-linux-gnu-gfortran" >> $GITHUB_ENV
echo "PKG_CONFIG_PATH=/usr/lib/aarch64-linux-gnu/pkgconfig" >> $GITHUB_ENV

- name: Build binaries
run: yarn prebuild -a ${{ env.TARGET }}

- name: Print binary info
if: contains(matrix.os, 'ubuntu')
run: |
ldd build/**/node_sqlite3.node
if [ "${{ matrix.target }}" = "arm64" ]; then
PREFIX=aarch64-linux-gnu-
fi

${PREFIX}readelf -d build/**/node_sqlite3.node | grep "Shared library"
echo "---"
nm build/**/node_sqlite3.node | grep "GLIBC_" | c++filt || true
${PREFIX}nm build/**/node_sqlite3.node | grep "GLIBC_" | ${PREFIX}c++filt || true
echo "---"
file build/**/node_sqlite3.node

- name: Run tests
if: matrix.target != 'arm64' && !contains(matrix.os, 'ubuntu')
run: yarn test

- name: Upload binaries to commit artifacts
Expand All @@ -120,7 +143,6 @@ jobs:
target:
- linux/arm64
variant:
- bullseye
- alpine3.15
include:
# musl x64 builds
Expand Down