Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable and fix type-casting warnings #1689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rzhao271
Copy link

@rzhao271 rzhao271 commented Mar 3, 2023

While using Binskim to scan native node modules for VS Code, I learned that native node modules have type-casting warnings disabled by default.

This PR re-enables those warnings and fixes them.

The downstream PR, microsoft#32, has some comments on the sqlite3_bind_* changes.

@rzhao271
Copy link
Author

Hi @daniellockyer, I have updated the PR to fix the merge conflicts. I have also adjusted binding.gyp so that the build doesn't fail when a type-casting warning occurs.

@daniellockyer daniellockyer self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants