Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssl_fips to binding.gyp #1684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msotnikov
Copy link

@timmypidashev
Copy link

Seconding this, would be nice to have latest install without downgrading node-gyp.

@daniellockyer
Copy link
Member

Can someone explain why this is needed, or at least provide a repro to show the breaking case?

@timmypidashev
Copy link

timmypidashev commented Jan 20, 2024

Can someone explain why this is needed, or at least provide a repro to show the breaking case?

Its really an obligatory fix due to the latest node versions not playing nicely with node-gyp. I personally am now using an older version(node-sqlite3 5.1.6) to bypass this issue, as it seems the issue is some breaking feature in 5.1.7. I'm fairly new to node-gyp, so I can't really give an explanation as to why this fixes it. The really fun part is, downgrading node to lts variants or even older releases does not remove this error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants