Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first cut at #1655. I have some questions:
callback
params called?Database.backup('foo.db', ()=>console.log('finished'))
a complete example, or dostep()
andfinish
need to be called?The docs say
But later in the docs it says that
step(-1)
must be called.Then it also says in different places that
finish()
is both required and not required.Clearing up these ambiguities would help the dx.