Replaced value.should.be.empty() with node:assert

[EvanHahn]

This test-only change should have no user impact.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

This PR standardizes test assertions across multiple suites: it replaces Should.js assertions with Node's assert (including assert.deepEqual) and explicit type/truthiness checks, converts iterative membership checks to Set-based equality, replaces some lodash isPlainObject/empty checks with direct deep-equality checks, adds an assertExists import in one test, and modernizes sinon verifications to sinon.assert.calledOnceWithExactly(). No runtime code or exported/public signatures were changed; modifications are limited to test assertion styles and related test imports.

Possibly related PRs

• Replaced value.should.be.an.Array() with node:assert #26427: Also migrates tests from Should.js to Node's assert and updates overlapping test files (including themes.test.js) with similar assertion changes.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: replacing should.be.empty() assertions with node:assert equivalents across test files.
Description check	✅ Passed	The description is directly related to the changeset, accurately noting this is a test-only change with no user impact that replaces should.be.empty() with node:assert.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch should-be.empty-begone

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.40.5)

ghost/core/test/legacy/models/model-posts.test.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

Verify each finding against the current code and only fix it if needed.


In `@ghost/core/test/e2e-api/admin/integrations.test.js`:
- Around line 351-353: The inner callback parameter named "res" in the test
inside integrations.test.js shadows the outer "res" constant; rename the inner
parameter (for example to "response" or "result") and update its usage in the
arrow callback (e.g. assert.deepEqual(response.body, {})) to avoid the ESLint
no-shadow violation while preserving the exact assertion logic in the test
function.

[coderabbitai]

🤖 Fix all issues with AI agents

Verify each finding against the current code and only fix it if needed.


In `@ghost/core/test/e2e-api/admin/redirects.test.js`:
- Line 2: Remove the unused import of the should assertion library: delete the
require statement that assigns to the symbol "should" (the top-level const
should = require('should');) since all assertions use Node's assert.deepEqual(),
leaving no references to "should" in the file; ensure no other references remain
after removal and run the tests to verify.

🧹 Nitpick comments (1)

🤖 Fix all nitpicks with AI agents

Verify each finding against the current code and only fix it if needed.


In `@ghost/core/test/e2e-api/admin/redirects.test.js`:
- Line 2: Remove the unused import of the should assertion library: delete the
require statement that assigns to the symbol "should" (the top-level const
should = require('should');) since all assertions use Node's assert.deepEqual(),
leaving no references to "should" in the file; ensure no other references remain
after removal and run the tests to verify.

ghost/core/test/e2e-api/admin/redirects.test.js (1)

2-2: Remove unused should import.

The should module is imported but no longer used in this file. All assertions use assert.deepEqual() from Node's strict assertion module.

Proposed fix

 const assert = require('node:assert/strict');
-const should = require('should');
 const supertest = require('supertest');

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/test/e2e-api/admin/redirects.test.js` at line 2, Remove the unused
import of the should assertion library: delete the require statement that
assigns to the symbol "should" (the top-level const should = require('should');)
since all assertions use Node's assert.deepEqual(), leaving no references to
"should" in the file; ensure no other references remain after removal and run
the tests to verify.