Skip to content

Restricted member emails to light mode only#25663

Merged
peterzimon merged 8 commits intomainfrom
restrict-member-emails-light-mode-only
Jan 13, 2026
Merged

Restricted member emails to light mode only#25663
peterzimon merged 8 commits intomainfrom
restrict-member-emails-light-mode-only

Conversation

@peterzimon
Copy link
Contributor

@peterzimon peterzimon commented Dec 9, 2025

ref https://linear.app/ghost/issue/DES-1169/email-cta-for-signups-lacks-contrast-when-received-in-dark-mode

  • The transactional member emails had a problem that whenever the accent color was set to pure black, the contrast on the buttons was low. After experimenting with various solutions, it seems like the most reliable one is to restrict the available modes in Apple Mail to light only.

Note

Ensures consistent light-mode rendering for member transactional emails to avoid low-contrast CTAs in dark mode.

  • Add <meta name="color-scheme" content="light only"> and <meta name="supported-color-schemes" content="light"> to signin.js, signup.js, signup-paid.js, subscribe.js, and update-email.js
  • Update e2e snapshots to reflect new meta tags in email HTML

Written by Cursor Bugbot for commit 0f58f7d. This will update automatically on new commits. Configure here.

peterzimon and others added 2 commits December 8, 2025 16:55
ref https://linear.app/ghost/issue/DES-1169/email-cta-for-signups-lacks-contrast-when-received-in-dark-mode

- The transactional member emails had a problem that whenever the accent color was set to pure black, the contrast on the buttons was low. After experimenting with various solutions, it seems like the most reliable one is to restrict the available modes in Apple Mail to light only.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Walkthrough

This pull request adds color scheme metadata to five email template files within the Ghost member services. Each file receives two identical meta tags in the HTML head section: one declaring color-scheme set to "light only" and another declaring supported-color-schemes set to "light". The changes are purely additive, with no modifications to logic, control flow, or public APIs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Notes:

  • Homogeneous, repetitive change applied uniformly across five email template files
  • Only static metadata additions to HTML head; no functional or behavioral modifications
  • Consistency check across all five files is straightforward given the identical nature of edits
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately describes the main change: adding color-scheme meta tags to restrict member emails to light mode only across five email templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the problem (low contrast CTAs in dark mode) and the solution (restricting to light mode only by adding meta tags across five email files).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterzimon peterzimon merged commit ae1a74a into main Jan 13, 2026
38 checks passed
@peterzimon peterzimon deleted the restrict-member-emails-light-mode-only branch January 13, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants