-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added job for email link click processing #21845
Draft
9larsons
wants to merge
8
commits into
main
Choose a base branch
from
handle-redirect-clicks-job
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/ghost/issue/ENG-1815/ ref https://linear.app/ghost/issue/ENG-1817/ - created a job queue entry for processing email click redirect actions Our existing handling relies on a sequence of DomainEvents, resulting a couple updates by different services. The challenge here is that while we maintain the walls around each particular service, this is creating performance issues for Ghost under heavy load. This change provides a pathway for us to respond to the redirect lookup as far as possible *while* encapsulating the actions needed by Ghost's main process within the response lifecycle, such that we do not create additional load on Ghost by accepting a new request before all the processing is done with the previous. In other words, we have a request queue and gate requests as a means of not overhwleming Ghost. We need to ensure that any processing due to a request is contained in that response lifecycle, even if it means very slight delays in returning the response to the user. We have a new model here instead of creating and emitting events, we inject the job creation fn into the service package as a cleaner means of creating the job. This allows us to keep the job in the service wrapper (within ghost/core) which is necessary to use knex and other imports like the settings cache.
Todo:
Some thoughts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/ENG-1815/
ref https://linear.app/ghost/issue/ENG-1817/
Our existing handling relies on a sequence of DomainEvents, resulting a couple updates by different services. The challenge here is that while we maintain the walls around each particular service, this is creating performance issues for Ghost under heavy load.
This change provides a pathway for us to respond to the redirect lookup as far as possible while encapsulating the actions needed by Ghost's main process within the response lifecycle, such that we do not create additional load on Ghost by accepting a new request before all the processing is done with the previous.
In other words, we have a request queue and gate requests as a means of not overhwleming Ghost. We need to ensure that any processing due to a request is contained in that response lifecycle, even if it means very slight delays in returning the response to the user.
We have a new model here instead of creating and emitting events, we inject the job creation fn into the service package as a cleaner means of creating the job. This allows us to keep the job in the service wrapper (within ghost/core) which is necessary to use knex and other imports like the settings cache.