Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook now runs out of the box on Colab #487

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sakshamio
Copy link

@sakshamio sakshamio commented Sep 22, 2023

Addresses 1/4th of #387

@anupamamurthi
Copy link
Collaborator

Hi @sakshamio Wondering, were you able to successfully run the notebook?

I had a few issues

  1. The notebook references common_utils.py but it is inside the examples package and not part of AIF360 library and python is unable to find a pointer to it at runtime.

In order to fix this, I would recommend moving common_utils into AIF360 itself - so that the module will be built as part of the library.

  1. Even after fixing the above, the notebook fails as it is unable to locate "adult dataset"
    IOError: [Errno 2] No such file or directory: '/usr/local/lib/python3.10/dist-packages/aif360/datasets/../data/raw/adult/adult.data'
    To use this class, please download the following files:

    https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.data
    https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.test
    https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.names

and place them, as-is, in the folder:

/usr/local/lib/python3.10/dist-packages/aif360/data/raw/adult

My recommendation will be to do two things

  1. add a !wget (or use requests) and download the files as part of the notebook
  2. you will need to override "load_preproc_data_compas" function so that it can optionally take a file directory as input. Right now, it simply takes "adult" as input and the path is hardcoded.

Let me know if all this makes sense.

Copy link
Collaborator

@anupamamurthi anupamamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants