Fixed str to int conversion issue #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed str to int conversion issue Signed-off-by: padmajaborwankar <[email protected]>
| @@ -10,7 +10,7 @@ def custom_preprocessing(df): | |||
| """ | |||
|
|
|||
| # Group age by decade | |||
| df['Age (decade)'] = df['age'].apply(lambda x: x//10*10) | |||
| df['Age (decade)'] = df['age'].astype(int).apply(lambda x: x//10*10) | |||
There was a problem hiding this comment.
Can we group integers or it is only feasible to group str?
There was a problem hiding this comment.
The 'age' had a String datatype due to which it was typecasted to integer and grouped as a decade.
|
It'd be great if you can link to the issue #421 👍 |
anupamamurthi
changed the title
mnagired
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
although I was unable to recreate the bug itself, the changes don't break anything (tested on aif360==0.5.0 env) so it looks good to me
P.S. when doing print(type(df['age'].values[0])) on the line before the comment "Group age by decade", it looks like the type is <class 'numpy.int64'>, which explains why the issue wasn't able to be recreated.
Regardless, it's good to explicitly do astype(int)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed str to int conversion issue
Signed-off-by: Padmaja Borwankar [email protected]