feat: sensor support integration #141

Neosoulink · 2024-10-11T21:37:02Z

Summary

This PR comes with the sensor intersection support!

Enable users to use custom colliders as sensors:

<CuboidCollider
   :args="[10, 3, 0.5]"
   :position="[0, 3, 3]"
   activeCollision
   sensor
   @intersection-enter="onIntersectionEnter"
   @intersection-exit="onIntersectionExit"
/>

Logs

Fix debug lines bounding-box availability
Add new vNode extended types
- TresVNodeObject
- TresVNode
Add a TresObject to collider components
Add sesnor demo
Implement intersection feature

Record

Screen.Recording.2024-10-11.at.11.35.00.PM.mov

Documentation addition

Sensor

The Sensor feature allows events to be triggered when there's an intersection or in other words, when the collider is traversed by another collider.

The traversed Collider (or the collider that will trigger events), is the sensor and should set the activeCollision and sensor properties to true.
By passing the above properties, the collider will no longer be affected by the physics law and will now start triggering the following intersection events:

@intersection-enter: When another collider starts to traverse the sensor
@intersection-exit: When another collider leave the sensor

I.e:

<RigidBody type="fixed">
  <CuboidCollider
    :args="[10, 3, 0.5]"
    :position="[0, 3, 3]"
    activeCollision
    sensor
    @intersection-enter="onIntersection1Enter"
    @intersection-exit="onIntersectionExit"
  />

  <CuboidCollider
    :args="[10, 3, 0.5]"
    :position="[0, 3, -3]"
    activeCollision
    sensor
    @intersection-enter="onIntersection2Enter"
    @intersection-exit="onIntersectionExit"
  />
</RigidBody>

This PR will resolve #107

Neosoulink · 2024-10-11T21:45:49Z

⚠️ IMPORTANT NOTE:

I'm getting the unsupported properties warning when using custom colliders with intersection events:

[Vue warn]: Extraneous non-emits event listeners (intersectionEnter, intersectionExit) were passed to component but could not be automatically inherited because component renders fragment or text root nodes. If the listener is intended to be a component custom event listener only, declare it using the "emits" option. 
  at <Anonymous name="cuboid-sensor" args= Array(3) position= Array(3)  ... > 
  at <RigidBody type="fixed" > 
  at <Physics debug="" > 
  at <App>

I understand this is coming from my emitIntersection utility, where I'm trying to get the correct collider component:

export const emitIntersection = (
  source: sourceTarget,
  target: sourceTarget,
  started: boolean,
) => {
  const collisionType: collisionType = started ? 'enter' : 'exit'
  const colliderNode = (source.object as any)?.__vnode?.children?.[1]?.children?.find((child: any) => child?.component?.exposed?.instance?.value === source.context.collider)

  colliderNode?.component?.emit?.(`intersection-${collisionType}`, { source, target })
}

I don't have a better solution right now to solve the issue, but I'll try to dig in to see if I can improve the integration.

cc: @JaimeTorrealba

alvarosabu · 2024-10-18T13:24:08Z

I understand this is coming from my emitIntersection utility, where I'm trying to get the correct collider component:

export const emitIntersection = (
  source: sourceTarget,
  target: sourceTarget,
  started: boolean,
) => {
  const collisionType: collisionType = started ? 'enter' : 'exit'
  const colliderNode = (source.object as any)?.__vnode?.children?.[1]?.children?.find((child: any) => child?.component?.exposed?.instance?.value === source.context.collider)

  colliderNode?.component?.emit?.(`intersection-${collisionType}`, { source, target })
}

I don't have a better solution right now to solve the issue, but I'll try to dig in to see if I can improve the integration.

Hi @Neosoulink this is probably happening because those new intersection-* emits are not declared in the emit definition here https://github.com/Tresjs/tres/blob/af704c1e8e146608d34543325af67b0b43703f20/src/components/TresCanvas.vue#L79

Is it colliderNode.component a Tres component?

Neosoulink · 2024-10-18T15:39:31Z

Is it colliderNode.component a Tres component?

Hi @alvarosabu,
No, but it uses the Tres component to get the Collider component, colliderNode.component is the current Collider component triggering the intersection event.

Note: Probably next week I'll create new types instead of using any

alvarosabu · 2024-10-21T13:58:45Z

Is it colliderNode.component a Tres component?

Hi @alvarosabu, No, but it uses the Tres component to get the Collider component, colliderNode.component is the current Collider component triggering the intersection event.

Note: Probably next week I'll create new types instead of using any

Hi @Neosoulink if you are in control of the Collider Component, I think you need define the emits using defineEmits https://vuejs.org/api/sfc-script-setup#defineprops-defineemits to get rid of that error.

Neosoulink · 2024-10-21T14:12:47Z

Hi @Neosoulink if you are in control of the Collider Component, I think you need define the emits using defineEmits https://vuejs.org/api/sfc-script-setup#defineprops-defineemits to get rid of that error.

Okay, let me try this ✅

JaimeTorrealba · 2024-10-25T09:09:55Z

@Neosoulink in order to use the same "system" that I use, you should emit the events in the parent, the RigidBody which is a 3DGroup...

I know it is just a draft (of end documentation) But if you check here:
https://github.com/Tresjs/rapier/blob/main/docs/components/collider.md

The solution I came was to emit the event in the parent.

The BaseCollider is not a Tres component and doesn't have the same vNode properties (in fact is just a <slot /> which is empty), but the RigidBody does.

You can check here how I handle it: https://github.com/Tresjs/rapier/blob/main/src/utils/collisions.ts#L8

Except that, this is a nice work, thank you.

PS: Don't forget to submit the documentation, is missing.

Neosoulink · 2024-10-25T09:40:32Z

@JaimeTorrealba I see now, and it's also joining the @alvarosabu note...
But Sensor events should be triggered from the Collider (yes, it's a <slot />).

In that case, we have to define emits directly in the project,
Something like here: https://github.com/Tresjs/tres/blob/af704c1e8e146608d34543325af67b0b43703f20/src/components/TresCanvas.vue#L79

Neosoulink · 2024-10-28T14:49:21Z

Hi @alvarosabu @JaimeTorrealba, I just pushed the fix for the properties warning issue.

But I'm not sure if I should add documentation in this PR as well, I mean this PR will get bigger

Otherwise, this PR is ready for review

alvarosabu · 2024-10-28T15:41:19Z

src/components/colliders/BaseCollider.vue

@@ -86,5 +98,7 @@ onUnmounted(() => {
 </script>

 <template>
-  <slot></slot>
+  <TresGroup>


The reason to use a <TresGroup> here is what @JaimeTorrealba mentioned here #141 (comment) ?

Yes, exactly!

I was thinking about this, a <TresGroup /> makes no sense here... Maybe add a "dummy" object like a "TresObject3D".

Something that can emit an event (a Tres-vue component) but also something that makes sense when you inspect the hierarchy tree in Three.js.

Yes @JaimeTorrealba, I used a Group to match what was done in the RigidBody component,

But in reality, both of them should use Object3D instead.

I see, I mean, we use TresGroup a lot on cientos for some of the abstractions, so I'm fine either way.

@JaimeTorrealba what does the dummy object would look like?

My suggestion is exactly that a "TresObject3D" (we generally used a dummy object3D in instanceMesh) it would solve the issue, also we can add (optionally) some :name="ColliderId" attribute, this way if you look into the threeJs scene makes more sense than a plain TresGroup, right? Or any other data/value that identify as a collider. All these are just suggestions., @alvarosabu.

@Neosoulink IDK if I misunderstand your last comment, but no <RigidBody> receive slots, it makes sense to be a TresGroup

No, there's no misunderstanding,
I was just clarifying the topic of using an Object3D.

alvarosabu · 2024-10-28T15:43:38Z

Regarding

Hi @alvarosabu @JaimeTorrealba, I just pushed the fix for the properties warning issue.

But I'm not sure if I should add documentation in this PR as well, I mean this PR will get bigger

Otherwise, this PR is ready for review

It's expected to have documentation in the same scope as the PR whenever there is a new feature or bugfix. It's also a way reviewers can understand the code changes quicker as they were a new user.

Neosoulink · 2024-10-28T18:00:20Z

It's expected to have documentation in the same scope as the PR whenever there is a new feature or bugfix. It's also a way reviewers can understand the code changes quicker as they were a new user.

Got it

### Description - Add new `vNode` extended types - `TresVNodeObject` - `TresVNode` - Add a `TresObject` to collider

Neosoulink · 2024-10-29T14:43:17Z

I added a minimal senor documentation

cc: @alvarosabu @JaimeTorrealba

JaimeTorrealba · 2024-11-03T18:52:07Z

src/components/Physics.vue

+      started,
+    )
+
+    if (started) {


A small improvement here.
I know this is the approach of R3F but if you pay attention to my collisionEmisor I handle the state (started true or false) in the function itself, this way we don't have to put an extra if in Physic and also don't have to repeat the emitIntersection function. Also keep consistency in the code

Yes, but it was also my design choice to be able to trigger the starting and the ending.
But yeah, let me correct this

I made the change @JaimeTorrealba

JaimeTorrealba

I think we can improve this in the future in order to accept automatic colliders too.

But the implementation is stable, thanks for this one

Neosoulink · 2024-11-07T17:51:59Z

I think we can improve this in the future in order to accept automatic colliders too.

But the implementation is stable, thanks for this one

I spend time looking for a good way to implement it.

Let's say you have your RigidBody and add the sensor property. Will the sensor events (Enter & Exit) be triggered when a collider transverses any collider inside that RigidBody?

Neosoulink requested review from alvarosabu and JaimeTorrealba October 11, 2024 21:37

Neosoulink self-assigned this Oct 11, 2024

alvarosabu reviewed Oct 28, 2024

View reviewed changes

alvarosabu added feature needs-documentation p3-significant High-priority enhancement (priority) labels Oct 28, 2024

Neosoulink added 5 commits October 28, 2024 20:12

feat: implement intersection feature

0925c12

feat(playground): add sesnor demo

c775f87

fix(playground): remove unsupported name

efbdf09

fix(core): debug line bounding-box availability

0714ee0

fix(core): unsupported props warns correction

1b37050

### Description - Add new `vNode` extended types - `TresVNodeObject` - `TresVNode` - Add a `TresObject` to collider

Neosoulink force-pushed the feat/sensor branch from 5629170 to 1b37050 Compare October 28, 2024 18:12

docs(component): minimal sensor documentation

bc48f47

fix(docs): minor

6452d33

JaimeTorrealba reviewed Nov 3, 2024

View reviewed changes

refactor(core): improve emitIntersection integration

c2eb175

Neosoulink requested review from alvarosabu and JaimeTorrealba November 4, 2024 12:20

refactor(core): use TresObject3D

20463a7

Neosoulink force-pushed the feat/sensor branch from 7b6409c to 20463a7 Compare November 6, 2024 20:21

JaimeTorrealba approved these changes Nov 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: sensor support integration #141

feat: sensor support integration #141

Neosoulink commented Oct 11, 2024 •

edited

Loading

Neosoulink commented Oct 11, 2024

alvarosabu commented Oct 18, 2024

Neosoulink commented Oct 18, 2024 •

edited

Loading

alvarosabu commented Oct 21, 2024

Neosoulink commented Oct 21, 2024

JaimeTorrealba commented Oct 25, 2024

Neosoulink commented Oct 25, 2024

Neosoulink commented Oct 28, 2024

alvarosabu Oct 28, 2024

Neosoulink Oct 28, 2024

JaimeTorrealba Oct 28, 2024

Neosoulink Oct 29, 2024

alvarosabu Oct 29, 2024

JaimeTorrealba Nov 2, 2024

Neosoulink Nov 2, 2024

alvarosabu commented Oct 28, 2024

Neosoulink commented Oct 28, 2024

Neosoulink commented Oct 29, 2024

JaimeTorrealba Nov 3, 2024

Neosoulink Nov 4, 2024

Neosoulink Nov 4, 2024

JaimeTorrealba left a comment

Neosoulink commented Nov 7, 2024

feat: sensor support integration #141

Are you sure you want to change the base?

feat: sensor support integration #141

Conversation

Neosoulink commented Oct 11, 2024 • edited Loading

Summary

Logs

Record

Documentation addition

Sensor

Neosoulink commented Oct 11, 2024

alvarosabu commented Oct 18, 2024

Neosoulink commented Oct 18, 2024 • edited Loading

alvarosabu commented Oct 21, 2024

Neosoulink commented Oct 21, 2024

JaimeTorrealba commented Oct 25, 2024

Neosoulink commented Oct 25, 2024

Neosoulink commented Oct 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alvarosabu commented Oct 28, 2024

Neosoulink commented Oct 28, 2024

Neosoulink commented Oct 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaimeTorrealba left a comment

Choose a reason for hiding this comment

Neosoulink commented Nov 7, 2024

Neosoulink commented Oct 11, 2024 •

edited

Loading

Neosoulink commented Oct 18, 2024 •

edited

Loading