Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages exports types #153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 20, 2024

This PR fixed subpackges exports for node10 and node16 and also includes:

  • adds "typesVersions" to fix node10 types resolutions
  • adds rollupTypes: true to rollup dts plugin to emit vue types in js instead on vue.d.ts
  • pins typescript to v5.4.2, we need some ts update ([api-extractor] Update TypeScript version from 5.4.2 to latest microsoft/rushstack#5052)
  • adds typescript and @arethetypeswrong/cli to ignore deps in renovate.json
  • fixes types in playground (tsconfig.json) and playground-nuxt (added ts entry to resolve types and also updated the dependency to use workspace protocol instead using npm registry)
  • adds @arethetypeswrong/cli to check types are not broken: added also test:attw script, we need to figure out where we can run it on CI here
  • patches @arethetypeswrong/cli to allow run test:attw script on Windows (running npm pack on Windows failing) updating npm cli from 10.3.2 to 10.9 works on my Windows

/cc @brc-dd thx for the help

Looks like some ts dependencies not yet updated, api extractor failing when using ts 5.7.2 but using pnpm.overrides fix the problem: @brc-dd thx again

Running test:attw script:

image

@userquin userquin requested a review from alvarosabu as a code owner December 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant