Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify modules when autoimport post-processing #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alvarosabu
Copy link
Member

This PR fixes the issue with the stable release of post-processing

@alvarosabu alvarosabu added bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) labels Dec 19, 2024
@alvarosabu alvarosabu self-assigned this Dec 19, 2024
@alvarosabu
Copy link
Member Author

@Tinoooo @damienmontastier, we have an issue with compatibility because of how we decided to architecture the @tresjs/post-processing package. Nuxt module tries to auto import the default, since there are two modules, I tried adding them but names collide. We need to go another route for the post-processing package and probably have a breaking change there

@damienmontastier
Copy link

damienmontastier commented Dec 19, 2024

@alvarosabu Instead of having 2 exports (for three and pmdrs), would it be better to have a UnrealBloom folder, with the Three.js effect and the Pmdrs effect inside?

  • UnrealBloom
      - Pmdrs
      - Three
  • Glitch
      - Pmdrs
      - Three
  • etc..

To call each effect (Glitch, UnrealBloom, etc), we could imagine using either :

  • 2 components <GlitchPmdrs /> and <GlitchThree />.

OR

  • 1 component <Glitch source=“pdmrs” /> which then dynamically calls the one concerned

@userquin
Copy link
Member

@damienmontastier @alvarosabu Tresjs/post-processing#152

@userquin
Copy link
Member

I'm going to prepare another PR here (will supersede this PR), we only need to do some hack before registering the imports...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants