add example for compressing bc6h #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
approved these changes
May 3, 2024
|
When I used rgba8 data in the past, I either got an image duplicated horizontally with wrong colors (wrong bytes per pixel) or just a segfault in the kernel. I would assume intel_tex uses f16 to support HDR. f32 -> f16 -> bc6h works as expected in my image_dds crate. |
|
This is useful! Why no merge? |
|
Commits aren't signed, so I can't merge them. |
Fwiw - I do agree this is useful and should be merged. As soon as the commits are signed the CI and merge rules will let me merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior makes sense but isn't very obvious. Hopefully this saves someone the pain I endured a while ago figuring out why bc6h encoding crashed or didn't work as expected. It might be a good idea to add asserts for the surface data length in the future. Messing up the stride or data length will likely result in segfaults.