Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some confusion over Orphanet identifiers in EFO #403

Open
gaurav opened this issue Jan 22, 2025 · 0 comments
Open

Some confusion over Orphanet identifiers in EFO #403

gaurav opened this issue Jan 22, 2025 · 0 comments

Comments

@gaurav
Copy link
Collaborator

gaurav commented Jan 22, 2025

The EFO code has two pieces of code that appear to be trying to exclude Orphanet identifiers from the concords generated from EFO:

if otherid.startswith("ORPHANET"):
print(row["match"])
print(other)
print(otherid)
exit()

if otherid.startswith("ORPHANET"):
print(row["match"])
print(other)
print(otherid)
exit()

However, because these methods call exit(), it looks to me like they used to stop generating output when they hit their first Orphanet identifier? Secondarily, because this code didn't standardize capitalization, it was probably missing many (all?) Orphanet identifiers anyway.

I've updated that code in PR #402 so that we skip Orphanet identifiers instead, and so now these identifiers are being skipped.

So we need to figure out:

  1. What the original intention of this code was, and
  2. Whether we want to skip Orphanet identifiers going forward
@gaurav gaurav mentioned this issue Jan 22, 2025
@gaurav gaurav added this to the Babel February 2025 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant