Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced support for XML files detection #26

Merged
merged 2 commits into from
Nov 17, 2018

Conversation

sandrock
Copy link

@sandrock sandrock commented Oct 9, 2018

Here is a PR to enhance support for XML files. I included 4 XML files:

  • XML UTF-8 No-BOM
  • XML UTF-8 with BOM
  • XML UCS-2 Little Endian (UTF-16) with BOM
  • XML UCS-2 Big Endian with BOM

See Byte order mark and UTF-16 on wikipedia.

It should solve issue #24

@sandrock
Copy link
Author

Hello. Any news?

@clarkis117
Copy link
Collaborator

Looks good :shipit:

@clarkis117 clarkis117 merged commit aa397aa into TonyValenti:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants