Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add tox_options_set_savedata, deprecate old functions. #2840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 25, 2025

This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 25, 2025
@github-actions github-actions bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Jan 25, 2025
@iphydf iphydf force-pushed the savedata branch 4 times, most recently from 092015c to ce5870d Compare January 25, 2025 15:12
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (7c9fa37) to head (dabae03).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/tox_options.c 69.56% 7 Missing ⚠️
testing/fuzzing/toxsave_fuzz_test.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
- Coverage   72.14%   72.02%   -0.12%     
==========================================
  Files         152      152              
  Lines       31182    31192      +10     
==========================================
- Hits        22496    22467      -29     
- Misses       8686     8725      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf marked this pull request as ready for review January 25, 2025 15:25
@iphydf iphydf force-pushed the savedata branch 3 times, most recently from dabae03 to 17045ee Compare January 27, 2025 15:29
This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Development

Successfully merging this pull request may close these issues.

1 participant