Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Tox_Options to tox_options.h. #2837

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 24, 2025

For backwards compatibility, we also #include "tox_options.h" in tox.h, but in 0.3.0 we can break that so most toxcore client code doesn't need the options, only the part that creates the instance.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 24, 2025
@github-actions github-actions bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Jan 24, 2025
@iphydf iphydf force-pushed the tox-options branch 9 times, most recently from 8c2cf64 to df3e41c Compare January 24, 2025 18:03
@iphydf iphydf marked this pull request as ready for review January 24, 2025 18:17
For backwards compatibility, we also `#include "tox_options.h"` in
`tox.h`, but in 0.3.0 we can break that so most toxcore client code
doesn't need the options, only the part that creates the instance.
@pull-request-attention pull-request-attention bot assigned iphydf and Green-Sky and unassigned iphydf Jan 25, 2025
@pull-request-attention pull-request-attention bot assigned iphydf and unassigned Green-Sky Jan 25, 2025
@toktok-releaser toktok-releaser merged commit d408c98 into TokTok:master Jan 25, 2025
62 checks passed
@iphydf iphydf deleted the tox-options branch January 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Development

Successfully merging this pull request may close these issues.

None yet

3 participants