Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Check that onion IP/Port packing worked. #2830

Merged
merged 1 commit into from
Jan 15, 2025

cleanup: Check that onion IP/Port packing worked.

5cca245
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Check that onion IP/Port packing worked. #2830

cleanup: Check that onion IP/Port packing worked.
5cca245
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Jan 15, 2025 in 3s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Check that onion IP/Port packing worked.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : cleanup: Check that onion IP/Port packing worked.

If it doesn't work for some reason, right now it would cause trouble
(e.g. buffer overrun).
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : If it doesn't work for some reason, right now it would cause trouble (e.g. buffer overrun).

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}