Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix bad design of remoting call #539

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(design): fix bad design of remoting call #539

merged 3 commits into from
Nov 28, 2024

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Nov 28, 2024

closes #540

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (4fda560) to head (7891c51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
actors/receive_context.go 81.25% 2 Missing and 1 partial ⚠️
actors/scheduler.go 83.33% 0 Missing and 2 partials ⚠️
client/client.go 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          46       46           
  Lines        4626     4649   +23     
=======================================
+ Hits         4016     4036   +20     
- Misses        482      484    +2     
- Partials      128      129    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit a4e7ad8 into main Nov 28, 2024
5 checks passed
@Tochemey Tochemey deleted the issue-fix branch November 28, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Fix poor remoting call api design
1 participant