Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove system ask timeout and pass timeout to asks #515

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Nov 11, 2024

BREAKING CHANGE

  • WithReplyTimeout removed from the ActorSystem option
  • All ask-based methods on PID and ReceiveContext timeout argument:
    • Ask
    • SendSync
    • BatchAsk
    • RemoteAsk
    • RemoteBatchAsk
  • No more system-wide ask timeout

closes #514

BREAKING CHANGE: - WithReplyTimeout removed
  - All ask-based methods on PID and context accept timeout argument
  - No more system-wide ask timeout
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.59%. Comparing base (ee09910) to head (aee47f8).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
actors/pid.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   87.74%   87.59%   -0.16%     
==========================================
  Files          46       46              
  Lines        4504     4497       -7     
==========================================
- Hits         3952     3939      -13     
- Misses        433      437       +4     
- Partials      119      121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 9760b03 into main Nov 11, 2024
4 of 5 checks passed
@Tochemey Tochemey deleted the issue-514 branch November 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing timeout in SendSync
1 participant