Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TLS support #501

Closed
wants to merge 6 commits into from
Closed

feat: add TLS support #501

wants to merge 6 commits into from

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Oct 21, 2024

closes #499
closes #500

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 46.10390% with 83 lines in your changes missing coverage. Please review.

Project coverage is 85.98%. Comparing base (d2bc226) to head (4767217).

Files with missing lines Patch % Lines
actors/actor_system.go 45.23% 59 Missing and 10 partials ⚠️
actors/option.go 41.17% 10 Missing ⚠️
actors/pid.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   87.40%   85.98%   -1.42%     
==========================================
  Files          45       45              
  Lines        4294     4437     +143     
==========================================
+ Hits         3753     3815      +62     
- Misses        426      498      +72     
- Partials      115      124       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey closed this Oct 24, 2024
@Tochemey Tochemey deleted the issue-500 branch October 24, 2024 23:07
@Tochemey
Copy link
Owner Author

This initial code path led to me a simple and clean way to add the mTLS. Abandoning this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS support
1 participant