-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add risingwave engine adapter support for sqlmesh. #3436
base: main
Are you sure you want to change the base?
Conversation
@lin0303-siyuan do you have plans to finish this? |
@tobymao Hi Toby, I have some issues last two weeks and plan to resume this week. |
Hi maintainers, I have pushed new commits and am willing to hear from your feedbacks about the risingwave engine adatper. |
Can you please also add a docs page for risingwave? See the existing ones for examples. It basically just needs to tell people how to install it, what the connection options are and any risingwave limitations / quirks that you are aware of |
Sure, please see the new commit. |
| `password` | The password to use for authentication with the RisingWave engine | string | N | | ||
| `port` | The port number of the RisingWave engine server | int | Y | | ||
| `database` | The name of the database instance to connect to | string | Y | | ||
| `role` | The role to use for authentication with the Postgres server | string | N | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postgres?
@@ -370,7 +378,7 @@ def test_create_table(ctx: TestContext): | |||
column_descriptions={"id": "test id column description"}, | |||
table_format=ctx.default_table_format, | |||
) | |||
results = ctx.get_metadata_results() | |||
results = ctx.get_metadata_results(schema=table.db) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed it for all adapters?
Risingwave engine adapter is functioning well with simple model tests like create view, post statements...