Skip to content

Commit

Permalink
Clarify labels
Browse files Browse the repository at this point in the history
  • Loading branch information
nedvna authored Apr 20, 2021
1 parent 6a97c1e commit f8a7032
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libvirt_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var (
libvirtVersionsInfoDesc = prometheus.NewDesc(
prometheus.BuildFQName("libvirt", "", "versions_info"),
"Versions of virtualization components",
[]string{"hypervisor_running_version", "libvirtd_running_version", "library_version"},
[]string{"hypervisor_running", "libvirtd_running", "libvirt_library"},
nil)
libvirtDomainInfoMetaDesc = prometheus.NewDesc(
prometheus.BuildFQName("libvirt", "domain_info", "meta"),
Expand Down Expand Up @@ -685,7 +685,7 @@ func CollectFromLibvirt(ch chan<- prometheus.Metric, uri string) error {
}
libvirtdVersion := fmt.Sprintf("%d.%d.%d", libvirtdVersionNum/1000000%1000, libvirtdVersionNum/1000%1000, libvirtdVersionNum%1000)

libraryVersionNum, err := libvirt.GetVersion() // virGetVersion, version of library, i.e. libvirt library used here, not the daemon
libraryVersionNum, err := libvirt.GetVersion() // virGetVersion, version of libvirt (dynamic) library used by this binary (exporter), not the daemon version
if err != nil {
return err
}
Expand Down

0 comments on commit f8a7032

Please sign in to comment.