Make adding new sensors to matter integration easier. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies adding new metrics.
It is much easier to add new sensors if we don't need to write boilerplate code for the reporting thread. Since reading and reporting values is much faster than measurement interval, having a single thread should not be a problem.
The way mutexes were used required writing a getter/setter pair for each new sensor value. We can get the same semantics by using std::atomic.
Since the file has been converted to C++ it makes sense to use C++ way to define symbols isolated to the current compilation module.
…ight before sending them. This way we can use NaN as a sign that the value is not available and not report zeros if the sensor is not connected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tim, thank you very much for indicator_matter. It is the easiest way to integrate SenseCAP Indicator with HA.
This pull request prepares indicator_matter for adding CO2 and tVOC reporting support. I've refactored the codebase so that adding new sensors required minimal amount of boilerplate code. For the ease of review I've split changes in a series of small commits, each touching a certain aspect.
I'll send separate request to actually add CO2 and tVOC support, which will be something like this: kibergus@ee6ea7a