Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some editions use external core #8896

Open
wants to merge 3 commits into
base: tiddlywiki-com
Choose a base branch
from

Conversation

Leilei332
Copy link
Contributor

This would make visiting https://tiddlywiki.com faster.

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 21106d5
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/678b9548f15bbf0008f219b1
😎 Deploy Preview https://deploy-preview-8896--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jermolene
Copy link
Member

Hi @Leilei332 historically, the file at the URI https://tiddlywiki.com/index.html serves both as the home page and as a distribution URL for people to download TiddlyWiki. I'd have no objection to externalising the core for other wikis such as https://tiddlywiki.com/dev or https://links.tiddlywiki.org or https://mws.tiddlywiki.com etc

@pmario
Copy link
Member

pmario commented Jan 17, 2025

@Leilei332 -- It seems empty-js is not built otherwise there should be a tiddlywiki.com/external-5.3.6.html which you should be able to load.

"external-js": [
"--render","$:/core/save/offline-external-js","[[external-]addsuffix<version>addsuffix[.html]]","text/plain",
"--render","$:/core/templates/tiddlywiki5.js","[[tiddlywikicore-]addsuffix<version>addsuffix[.js]]","text/plain"],

So imo the build system would need to be fixed -- It seems

@Leilei332 Leilei332 changed the title Make tiddlywiki.com use external core Make some editions use external core Jan 18, 2025
@Leilei332
Copy link
Contributor Author

@Leilei332 -- It seems empty-js is not built otherwise there should be a tiddlywiki.com/external-5.3.6.html which you should be able to load.

"external-js": [
"--render","$:/core/save/offline-external-js","[[external-]addsuffix<version>addsuffix[.html]]","text/plain",
"--render","$:/core/templates/tiddlywiki5.js","[[tiddlywikicore-]addsuffix<version>addsuffix[.js]]","text/plain"],

So imo the build system would need to be fixed -- It seems

This is because the external-js build task isn't included in build-site.sh:

图片

But I think we needn't add it back. While building the empty edition, its emptyexternalcore task is included, which builds https://tiddlywiki.com/empty-external-core.html

图片

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants