-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some editions use external core #8896
base: tiddlywiki-com
Are you sure you want to change the base?
Conversation
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @Leilei332 historically, the file at the URI https://tiddlywiki.com/index.html serves both as the home page and as a distribution URL for people to download TiddlyWiki. I'd have no objection to externalising the core for other wikis such as https://tiddlywiki.com/dev or https://links.tiddlywiki.org or https://mws.tiddlywiki.com etc |
@Leilei332 -- It seems empty-js is not built otherwise there should be a TiddlyWiki5/editions/tw5.com/tiddlywiki.info Lines 55 to 57 in 4478f44
So imo the build system would need to be fixed -- It seems |
This is because the But I think we needn't add it back. While building the empty edition, its |
This would make visiting https://tiddlywiki.com faster.