admin: Replace map() with forEach() if modifying

... the original array, for better performance
ThrRip · Dec 23, 2023 · 0a154de · 0a154de
1 parent ee59c7b
commit 0a154de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/admin/pages/playlist.vue b/packages/admin/pages/playlist.vue
@@ -137,13 +137,12 @@ async function viewPlaylistDataUpdate () {
     // Sort by song name or artist in alphabetical order
     if (viewPlaylistSortingColumn.value === 'name' || viewPlaylistSortingColumn.value === 'artist') {
       const pinyinPro = await import('pinyin-pro')
-      playlist.map((song) => {
+      playlist.forEach((song, index) => {
         // @ts-ignore
-        song[`${viewPlaylistSortingColumn.value}Pinyin`] =
+        playlist[index][`${viewPlaylistSortingColumn.value}Pinyin`] =
           // @ts-ignore
           pinyinPro.pinyin(song[viewPlaylistSortingColumn.value], { toneType: 'none', nonZh: 'consecutive' })
             .replaceAll(' ', '')
-        return song
       })
       playlist.sort((a, b) => {
         // @ts-ignore

diff --git a/packages/home/app.vue b/packages/home/app.vue
@@ -383,13 +383,12 @@ function viewPlaylistDataUpdate (tasks: Array<'shuffle' | 'sort'>) {
       // Sort by song name or artist in alphabetical order
       if (viewPlaylistSortingColumn.value === 'name' || viewPlaylistSortingColumn.value === 'artist') {
         const pinyinPro = await import('pinyin-pro')
-        playlist.map((song) => {
+        playlist.forEach((song, index) => {
           // @ts-ignore
-          song[`${viewPlaylistSortingColumn.value}Pinyin`] =
+          playlist[index][`${viewPlaylistSortingColumn.value}Pinyin`] =
             // @ts-ignore
             pinyinPro.pinyin(song[viewPlaylistSortingColumn.value], { toneType: 'none', nonZh: 'consecutive' })
               .replaceAll(' ', '')
-          return song
         })
         playlist.sort((a, b) => {
           // @ts-ignore