Skip to content

Commit

Permalink
Merge pull request #79 from ThinkR-open/bump-v
Browse files Browse the repository at this point in the history
update test and prep for CRAN submission
  • Loading branch information
dagousket authored Aug 7, 2024
2 parents d320329 + 9182da8 commit 739fb16
Show file tree
Hide file tree
Showing 9 changed files with 523 additions and 104 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: dockerfiler
Title: Easy Dockerfile Creation from R
Version: 0.2.3
Version: 0.2.4
Authors@R: c(
person("Colin", "Fay", , "[email protected]", role = c("cre", "aut"),
comment = c(ORCID = "0000-0001-7343-1846")),
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# dockerfiler 0.2.4

- remove native pipe thanks to @HenningLorenzen-ext-bayer, this enable to use of older R versions
- update `dock_from_renv()` test to catch all output lines

# dockerfile 0.2.3

- remove sysreqs.r-hub.io to use {pak} instead for system requirement detection
Expand Down
1 change: 0 additions & 1 deletion R/dock_from_renv.R
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,3 @@ dock_from_renv <- function(
dock
}


36 changes: 36 additions & 0 deletions dev/0-dev_history.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,39 @@ pkgdown::build_site()
devtools::build()
```

# Checks for CRAN release ----

## Copy the latest version of PREPARE_FOR_CRAN ----

```{r}
url <- "https://raw.githubusercontent.com/ThinkR-open/prepare-for-cran/master/README.md"
destination <- "dev/dev_history_PREPARE_FOR_CRAN.md"
download.file(url, destfile = destination, mode = "wb")
line <- grep(pattern = "# Prepare for CRAN ----", readLines(destination))
rstudioapi::navigateToFile(destination, line = line)
```

### Run the automated tests

## {dockerfiler} specificity : ----

### If `Check reverse dependencies` doesn't work`with `revdep_check()`:
### retrieve the GitHub files of the {dockerfiler}-dependent packages (golem),
### install attachment locally and check().

## BEFORE RELEASE: ----

### Add comments for CRAN
### Need to .gitignore this file

```{r}
usethis::use_cran_comments(open = rlang::is_interactive())
```

### Why we have `\dontrun{}`

```{r}
usethis::use_git_ignore("cran-comments.md")
usethis::use_git_ignore("CRAN-SUBMISSION")
```
Loading

0 comments on commit 739fb16

Please sign in to comment.