Add module functor to make CustomEvent with typed detail

[mununki]

This PR is related to reasonml-community/bs-webapi-incubator#204, reasonml-community/bs-webapi-incubator#203.

This PR adds a module functor to make a CustomEvent module with typed detail.

Example

module OnChangeDetail = {
  type t = {
    component: string,
    valueAsDate: Js.Date.t,
    value: string,
  }
}

let bar: OnChangeDetail.t = {
  component: "date-picker",
  valueAsDate: Js.Date.make(),
  value: "2022-01-28",
}

module NewOnChangeEvent = Webapi.Dom.CustomEvent.Make(OnChangeDetail)
let eventWithDetail = NewOnChangeEvent.make("event-with-detail")

Js.log(eventWithDetail->Webapi.Dom.CustomEvent.preventDefault) // still can use as before.
Js.log(eventWithDetail->NewOnChangeEvent.preventDefault) // can use with new CustomEvent
Js.log2("make", NewOnChangeEvent.makeWithOptions("foo", bar)) // can make with options..
Js.log((eventWithDetail->NewOnChangeEvent.detail).valueAsDate) // typed detail!

[TheSpyder]

Interesting. I hadn't considered doing it this way. I'll give it some thought, thanks!

[mununki]

committed the suggestions and fix the test.

[TheSpyder]

Looks good! I wonder whether we should delete the non-functor version in our v2 API update 😂

[TheSpyder]

Can this be done without the let t? I'm looking at the generated JS and it would be nice to avoid that part.

[mununki]

I guess you mentioned this generated js part

var t = {
  test: "test"
};

I'm afraid that the omission of this let t can't be made unless we change the test case to make instead of makeWithOption. or renaming the let t would be nicer such as let option maybe?

[TheSpyder]

But why does it need to be separate let? It's just a simple record, can't it be EventWithDetail.makeWithOptions("event-with-detail", { test: "test" }) ?

[mununki]

Oh, I misunderstood your intention. I removed it and pushed it.

[TheSpyder]

There was two of them - sorry, please make that change to both :)

[mununki]

Ah! I missed that, thx. I fixed it and pushed it. I reworded commit messages also.

[mununki]

@TheSpyder I don't know why exactly, but does my rebase to reword the commits cause the task-list-complete check running loop maybe?

[TheSpyder]

No, it's because resolving a comment thread doesn't automatically resolve all tasks within it:
#93 (comment)

I normally take care of that before merging if it's clear the task was done.

I hope to find time to finish reviewing and merge this in the next day or two.

[mununki]

@TheSpyder I got it. Thx.

[TheSpyder]

published as 0.6.1