Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toggleForced to force false #136

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

jcuenod
Copy link
Contributor

@jcuenod jcuenod commented Aug 27, 2024

Fixes #134

I took a quick look for other similar issues, but I didn't see any. Admittedly, I didn't look particularly carefully, though.

@TheSpyder
Copy link
Owner

Looks correct! Two things to fix; I need to add a contribution guide at some point 😂

  • there is a test that needs updating. The tests don't run any code, they are just there to check the API and code generation. Please make sure to test both true and false.
  • please add a changelog entry 👍

@jcuenod
Copy link
Contributor Author

jcuenod commented Aug 28, 2024

@TheSpyder let me know if those commits are need any revision.

Copy link
Owner

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 maybe one or two things I'd tweak but I can do that myself later.

@TheSpyder TheSpyder merged commit 495bdb3 into TheSpyder:main Aug 30, 2024
@jcuenod
Copy link
Contributor Author

jcuenod commented Aug 30, 2024

Ping me when you do. This came up in the first project I've used rescript in, so I'd be pleased to learn more idiomatic approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toggleForced should be able to send false
2 participants