-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#55 adding support for gradle #62
Conversation
Cheers, I'll review this tomorrow. |
Reviewing this in more detail, this PR is severely flawed. Firstly, non of the dependencies have any repositories ported over to the gradle files, secondly the java conventions plugin isn't really needed in this case, it should be the "java-library" one. In essence, this looks like someone just ran gradle init, pushed it into a branch and slapped a PR for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repositories for dependencies need to be actually included, gradle logic needs fixed beyond just typing "gradle init". Intellij config files may be removed as these weren't the issue.
PR is severely flawed, closing. |
#55