Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55 adding support for gradle #62

Closed

Conversation

sunydepalpur
Copy link

#55

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Sep 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sunydepalpur
Copy link
Author

Screenshot 2023-09-04 at 6 23 55 PM

@creatorfromhell
Copy link
Member

Cheers, I'll review this tomorrow.

@creatorfromhell
Copy link
Member

Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result:

image

@sunydepalpur
Copy link
Author

Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result:

image

You can use intellIJ for the build, I can share the, build approach

@sunydepalpur
Copy link
Author

Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result:
image

You can use intellIJ for the build, I can share the, build approach

Added the build configs in PR

@creatorfromhell
Copy link
Member

creatorfromhell commented Sep 6, 2023

Reviewing this in more detail, this PR is severely flawed. Firstly, non of the dependencies have any repositories ported over to the gradle files, secondly the java conventions plugin isn't really needed in this case, it should be the "java-library" one. In essence, this looks like someone just ran gradle init, pushed it into a branch and slapped a PR for it.

Copy link
Member

@creatorfromhell creatorfromhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repositories for dependencies need to be actually included, gradle logic needs fixed beyond just typing "gradle init". Intellij config files may be removed as these weren't the issue.

@creatorfromhell
Copy link
Member

PR is severely flawed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants