fix: export SafeActionClient type to make it portable
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@brunorodmoreira is attempting to deploy a commit to the Edoardo Ranghieri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi Bruno, thanks for your contribution. Does this solve #64? |
Yes! |
TheEdoRan
changed the title
SafeActionClient type to make it portable
|
🎉 This PR is included in version 7.9.3-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TheEdoRan
added a commit
that referenced
this pull request
Sep 13, 2024
Includes the `SafeActionClient` into the types export to make the inferred type of `createSafeActionClient` portable in order to avoid the error [TS2742](https://typescript.tv/errors/#ts2742). It enables declaring the action client in a shared package and import it in the other apps or packages. closes #64 Co-authored-by: Bruno Moreira <[email protected]>
|
@brunorodmoreira the fix indeed seems to work. It's just ridiculous to me that it was this easy all this time. Oh well, learned something today. Small but amazing contribution Bruno, thank you very much once again! Fix is included in v7.9.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the
SafeActionClientinto the types export to make the inferred type ofcreateSafeActionClientportable in order to avoid the error TS2742. It enables declaring the action client in a shared package and import it in the other apps or packages.Proposed changes
Put your proposed changes here.
I've just exported the type in the
index.types.tsfile.Related issue(s) or discussion(s)