Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various GH workflow improvements #98

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Various GH workflow improvements.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 4, 2023
@Panquesito7 Panquesito7 requested a review from siriak October 4, 2023 23:46
@Panquesito7 Panquesito7 added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 4, 2023
Comment on lines +12 to +13
# * * * * *
- cron: '0 0 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What extra space? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here
image

.github/workflows/documentation_workflow.yml Outdated Show resolved Hide resolved
@siriak
Copy link
Member

siriak commented Jan 10, 2024

Hey @Panquesito7, do you want to continue with this PR?

@Panquesito7
Copy link
Member Author

Hey @Panquesito7, do you want to continue with this PR?

Hey there! Sorry, I'm slowly checking all of my pending notifications. But sure, I'll fix the mentioned issues. Thanks! 🙂

@Panquesito7 Panquesito7 requested a review from siriak January 15, 2024 20:40
- name: Setup Git
run: |
echo "Setting up Git"
git config --global user.name github-actions[bot]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could get username and email from an environment variable? GITHUB_ACTOR or a similar one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants