Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added for Linear Search Algorithm #1753

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

HRIDYANSHU054
Copy link
Contributor

@HRIDYANSHU054 HRIDYANSHU054 commented Oct 25, 2024

Open in Gitpod know more

Describe your change:

Added tests and Wikipedia reference for Linear Search Algo

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (ff314a2) to head (cbea1fe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   84.76%   85.11%   +0.34%     
==========================================
  Files         378      378              
  Lines       19742    19740       -2     
  Branches     2955     2967      +12     
==========================================
+ Hits        16735    16801      +66     
+ Misses       3007     2939      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Search/LinearSearch.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a trivial linear search needs a lot of test coverage but why not.

@raklaptudirm raklaptudirm merged commit 85a55da into TheAlgorithms:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants