Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use check-style in #1630

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Mar 4, 2024

Open in Gitpod know more

Describe your change:

Currently in pre-commit npm run style is used. This formats the files but the changes are not added to the commit (and the command is successful). I would suggest to use npm run check-style, which fill fail, if there are some files requiring reformatting. It fits to the logic behind npm run test.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 marked this pull request as ready for review March 4, 2024 18:35
@raklaptudirm raklaptudirm merged commit d8cfdcd into TheAlgorithms:master Mar 4, 2024
3 checks passed
@vil02 vil02 deleted the check_style_in_precommit branch March 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants