Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: cleanup PascalTriangle #1606

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 3, 2024

Open in Gitpod know more

Describe your change:

This PR adds missing tests and cleans-up the implementation of PascalTriangle.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aaa376) 82.44% compared to head (760db43) 82.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
+ Coverage   82.44%   82.46%   +0.01%     
==========================================
  Files         377      377              
  Lines       19747    19745       -2     
  Branches     2884     2886       +2     
==========================================
+ Hits        16281    16282       +1     
+ Misses       3466     3463       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review February 3, 2024 12:40
@raklaptudirm raklaptudirm merged commit 10febce into TheAlgorithms:master Feb 9, 2024
3 checks passed
@vil02 vil02 deleted the cleanup_pascal_triangle branch February 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants