-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE before adding the token] chore: update codecov-action
to v4
#1605
[DO NOT MERGE before adding the token] chore: update codecov-action
to v4
#1605
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 377 377
Lines 19747 19747
Branches 2884 2885 +1
=======================================
Hits 16281 16281
Misses 3466 3466 ☔ View full report in Codecov by Sentry. |
It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ? I'm slightly uncomfortable with this as it requests permission to "act on my behalf": |
Yes.
I agree. |
I bit the bullet and authorized CodeCov to obtain the token, but it turns out that I can't edit repo secrets since I do not have "admin" permissions. This will require @Panquesito7 or @AnupKumarPanwar I believe. |
@appgurueu You should have admin access to the repository now |
Just in case: please make sure that |
Why would dependabot need the codecov token? It seems to work as-is: https://app.codecov.io/github/TheAlgorithms/JavaScript/commit/9010481c2930d65621f18f41c216f29fceaa8807 |
Without it, the |
know more
Describe your change:
Same as TheAlgorithms/Rust#670 - it contains the description of the problem.
Before merging, please add the token from https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings as
CODECOV_TOKEN
into the repo secrets.Checklist: