Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for SHA1 #1602

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 29, 2024

Open in Gitpod know more

Describe your change:

This PR adds test for SHA1. The test data comes from wikipeda or was verified with http://www.sha1-online.com/

  • Add missing tests.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 force-pushed the add_tests_for_sha1 branch from f44ea28 to cf67be0 Compare January 29, 2024 15:58
@vil02 vil02 force-pushed the add_tests_for_sha1 branch from cf67be0 to cee9652 Compare January 29, 2024 16:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf00041) 81.55% compared to head (9c5e0e4) 82.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   81.55%   82.44%   +0.89%     
==========================================
  Files         377      377              
  Lines       19747    19747              
  Branches     2865     2884      +19     
==========================================
+ Hits        16105    16281     +176     
+ Misses       3642     3466     -176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review January 29, 2024 16:10
appgurueu
appgurueu previously approved these changes Jan 29, 2024
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise fine.

---------

Co-authored-by: appgurueu <[email protected]>
@vil02 vil02 force-pushed the add_tests_for_sha1 branch from bd9cfa8 to 9c5e0e4 Compare January 29, 2024 20:07
@vil02 vil02 requested a review from appgurueu January 29, 2024 20:09
@raklaptudirm raklaptudirm merged commit 6aaa376 into TheAlgorithms:master Jan 31, 2024
3 checks passed
@vil02 vil02 deleted the add_tests_for_sha1 branch January 31, 2024 21:57
@vil02 vil02 mentioned this pull request Feb 1, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants