-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add tests for SHA1
#1602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
force-pushed
the
add_tests_for_sha1
branch
from
January 29, 2024 15:58
f44ea28
to
cf67be0
Compare
vil02
force-pushed
the
add_tests_for_sha1
branch
from
January 29, 2024 16:07
cf67be0
to
cee9652
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 81.55% 82.44% +0.89%
==========================================
Files 377 377
Lines 19747 19747
Branches 2865 2884 +19
==========================================
+ Hits 16105 16281 +176
+ Misses 3642 3466 -176 ☔ View full report in Codecov by Sentry. |
appgurueu
reviewed
Jan 29, 2024
appgurueu
reviewed
Jan 29, 2024
appgurueu
previously approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise fine.
vil02
force-pushed
the
add_tests_for_sha1
branch
from
January 29, 2024 20:02
96c5567
to
bd9cfa8
Compare
--------- Co-authored-by: appgurueu <[email protected]>
vil02
force-pushed
the
add_tests_for_sha1
branch
from
January 29, 2024 20:07
bd9cfa8
to
9c5e0e4
Compare
appgurueu
approved these changes
Jan 30, 2024
raklaptudirm
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
know more
Describe your change:
This PR adds test for
SHA1
. The test data comes from wikipeda or was verified with http://www.sha1-online.com/Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.