Skip to content

feat: Refactor Trie to O(1) Size, prevent duplicates, add lazy remove #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Refactor Trie to O(1) Size, prevent duplicates, add lazy remove #784

wants to merge 1 commit into from
+142 −9

Conversation

Zubayear
Copy link

This PR improves the Trie implementation:

  • Improve time complexity of Size() - O(1)
  • Remove unnecessary update of isLeaf flag on duplicate node
  • Empty string insertion prevented
  • Lazy remove decrements total count correctly
  • Added edge-case tests:
    • Empty string insertion
    • Substrings and shared prefixes
    • Removing non-existent words
    • Removing words sequentially
  • Added benchmark for Size()

This makes the Trie faster, safer, and properly tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zubayear