Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add binary exponentiation algorithm #1306

Closed
wants to merge 8 commits into from
Closed

feat: add binary exponentiation algorithm #1306

wants to merge 8 commits into from

Conversation

PraneethJain
Copy link

Description of Change

Implementation of the binary exponentiation algorithm, which calculates the nth power of an integer in O(log(n)) time.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@PraneethJain
Copy link
Author

Hey @realstealthninja, I've made the requested changes. Could you re review this?

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work i recommend adding more descriptive variables;
yes a and n are the common math notation but it increases readability imo.
but its completely fine if you prefer a^n notation lmk

PraneethJain and others added 2 commits October 2, 2023 11:52
Co-authored-by: realstealthninja <[email protected]>
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing!!! ❤️ the code is very elegant to read!

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 15, 2023
@PraneethJain
Copy link
Author

Hey, could someone review this?

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires review of code owners i'm afraid

@github-actions github-actions bot removed the Stale label Nov 18, 2023
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@PraneethJain
Copy link
Author

@Panquesito7

@github-actions github-actions bot removed the Stale label Dec 19, 2023
@PraneethJain PraneethJain closed this by deleting the head repository Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants