-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 465 coverage for hash table and tim sorter #500
Merged
siriak
merged 6 commits into
TheAlgorithms:master
from
gmottajr:feature/Issue-465_CoverageForHashTableAndTimSorter
Dec 4, 2024
Merged
Feature/issue 465 coverage for hash table and tim sorter #500
siriak
merged 6 commits into
TheAlgorithms:master
from
gmottajr:feature/Issue-465_CoverageForHashTableAndTimSorter
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/gmottajr/C-Sharp into feature/Issue-465_CoverageForHashTableAndTimSorter
Add_ShouldTriggerResize_WhenThresholdExceeded: Verifies that the HashTable triggers a resize when the number of elements exceeds the initial capacity. Add_ThrowsException_WhenKeyIsDefault: Ensures that adding a key with the default value (e.g., 0 for integers) throws an ArgumentNullException, as per the Add method’s validation. Add_ThrowsException_WhenValueIsDefault: Verifies that adding a value with the default value (e.g., null for reference types) throws an ArgumentNullException. Add_StoresValueCorrectly: Confirms that values are correctly stored and can be retrieved via the key after an Add operation. Get_ReturnsCorrectValue_ForExistingKey: Ensures that the correct value is returned when querying for an existing key. Get_ThrowsException_WhenKeyDoesNotExist: Verifies that accessing a non-existent key throws a KeyNotFoundException, maintaining expected behavior. Capacity_Increases_WhenResizeOccurs: Checks that the HashTable increases its capacity when the number of items exceeds the threshold, ensuring proper resizing. These tests aim to cover edge cases, resizing logic, and ensure correct behavior of the Add and Get methods, improving overall robustness and stability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 95.11% 95.16% +0.04%
==========================================
Files 267 267
Lines 10848 10848
Branches 1527 1527
==========================================
+ Hits 10318 10323 +5
+ Misses 403 400 -3
+ Partials 127 125 -2 ☔ View full report in Codecov by Sentry. |
siriak
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for HashTable to improve coverage of key behaviors
These tests aim to cover edge cases, resizing logic, and ensure correct behavior of the Add and Get methods, improving overall robustness and stability.