mpl, par: move to boost random number generator due to bug in STL #7136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniform_real has a bug in it where it can sometimes return 1.0 for a range when it's supposed to return [0,1.0). Lesson is don't use real for this purpose use int distribution. See the compiler bugs listed on this page for more info. https://en.cppreference.com/w/cpp/numeric/random/uniform_int_distribution Signed-off-by: Ethan Mahintorabi <[email protected]>
Signed-off-by: Ethan Mahintorabi <[email protected]>
Signed-off-by: Ethan Mahintorabi <[email protected]>
Signed-off-by: Ethan Mahintorabi <[email protected]>
Signed-off-by: Ethan Mahintorabi <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
@QuantamHD I opened this PR due to some merge conflicts that emerged in your PR. I resolved them and ran a Secure-CI whose needed metrics updates are being addressed in #3075 . Apologies for the delay with these changes, they ended up revealing some nasty bugs that took quite a while to understand. I hope we can move on with the changes here. The ownership of your updates are preserved. |
maliberty
approved these changes
Apr 14, 2025
Collaborator
|
❤️ |
QuantamHD
approved these changes
Apr 14, 2025
Collaborator
|
This is really awesome work. Thanks so much for your time in debugging these complex issues. |
Signed-off-by: Arthur Koucher <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6649.