Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsz: Try multiple repairs per iteration #6262

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kbieganski
Copy link
Contributor

@kbieganski kbieganski commented Nov 28, 2024

This makes RSZ try multiple fixes at once per iteration.
If the slack is worsened, fall back to one repair (old behavior).
Speeds up some specific designs significantly without really slowing anything else down.
The biggest gains I got were on a design that I can't share, unfortunately.

It follows a heuristic where the number of repairs is proprortional to the currently repaired path slack, with a cap of 10 repairs.
Probably not the best approach possible, but I tried multiple strategies and this one is the best so far.

Note: The code needs cleaning up, but I'll do that after I get some feedback.

asap7/<secret design 1>, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 641.23 1.00 1.57 0.00 4.46
Baseline 1031.58 1.61 0.77 -3.64 4.46

asap7/<secret design 2>, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 4882.00 1.00 0.71 -12.16 45.86
Baseline 8534.00 1.75 -22.62 -18.86 45.86

asap7/aes, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 38.53 1.00 -36.44 -1088.10 0.11
Baseline 38.43 1.00 -36.44 -1088.10 0.11

asap7/aes, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 13.92 1.00 0.09 -0.11 0.04
Baseline 14.16 1.02 0.09 -0.04 0.04

asap7/aes, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 64.13 1.00 -0.08 -1.94 0.31
Baseline 70.62 1.10 -0.07 -1.89 0.31

asap7/aes, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 55.13 1.01 0.32 0.00 0.13
Baseline 54.34 1.00 0.32 0.00 0.13

asap7/aes, floorplan

Branch Time [s] Relative WS TNS Power
Optimized 40.75 1.00 0.00 0.00 0.06
Baseline 40.97 1.01 0.00 -0.00 0.06

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment on lines +550 to +551
if (changed >= repairs_per_iter)
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: statement should be inside braces [google-readability-braces-around-statements]

Suggested change
if (changed >= repairs_per_iter)
break;
if (changed >= repairs_per_iter) {
break;
}

@kbieganski kbieganski marked this pull request as draft November 28, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant