Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drt: Fix pin double count and not appearing info. #6058

Merged
merged 1 commit into from
Oct 31, 2024
Merged

drt: Fix pin double count and not appearing info. #6058

merged 1 commit into from
Oct 31, 2024
+2 −6

Conversation

titan73
Copy link
Contributor

@titan73 titan73 commented Oct 30, 2024

Regression from 58b46bb.
Info message was never shown as pin count was always odd when performing the modulo.
Also simplify code even more.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@titan73
Copy link
Contributor Author

titan73 commented Oct 30, 2024

Note that before 58b46bb.
pin count was 20095 and after 29836 (double count printed 59672). Hope that was expected.

@titan73
Copy link
Contributor Author

titan73 commented Oct 30, 2024

There are similar code I'll simplify in another PR.

@titan73 titan73 closed this Oct 30, 2024
@titan73 titan73 reopened this Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@titan73 titan73 closed this Oct 31, 2024
@titan73
drt: Fix pin double count and not appearing info.
267ce64 
Regression from 58b46bb.
Info message was never shown as pin count was always odd when performing
the modulo.
Also simplify code even more.

Signed-off-by: Christian Costa <[email protected]>
@titan73 titan73 reopened this Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@osamahammad21 osamahammad21 merged commit d3654fe into The-OpenROAD-Project:master Oct 31, 2024
18 checks passed
@osamahammad21
Copy link
Member

@bnmfw FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osamahammad21 osamahammad21 osamahammad21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titan73 @osamahammad21