Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utl: add mechanism to make it easier to handle operation-specific settings #5995

Merged
merged 4 commits into from
Oct 23, 2024
Merged

utl: add mechanism to make it easier to handle operation-specific settings #5995

merged 4 commits into from
Oct 23, 2024

Conversation

AcKoucher
Copy link
Contributor

@AcKoucher AcKoucher commented Oct 22, 2024 •
edited
Loading

Generic functionality that will be useful for the match footprint/user_function_class task in #5577.

github-actions[bot]
github-actions bot reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/rsz/src/Resizer.cc Outdated Show resolved Hide resolved
maliberty
maliberty reviewed Oct 22, 2024
View reviewed changes
src/rsz/src/Resizer.cc Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AcKoucher AcKoucher changed the title rsz: add mechanism to make it easier to handle operation-specific settings utl: add mechanism to make it easier to handle operation-specific settings Oct 22, 2024
@AcKoucher AcKoucher marked this pull request as ready for review October 22, 2024 22:50
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AcKoucher
utl: fix license details
52f02eb 
Signed-off-by: Arthur Koucher <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AcKoucher
Copy link
Contributor Author

AcKoucher commented Oct 23, 2024 •
edited
Loading

I see on pr-merge tcl tests:

OpenROAD
error1 (tcl) pass
get_core_die_areas (tcl) pass
timing_api (py) pass
timing_api_2 (py) pass
timing_api_3 (py) pass
upf_test (tcl) pass
upf_aes (tcl)Sending interrupt signal to process

which seems to be on master as well.

@maliberty maliberty merged commit 8a31ef9 into The-OpenROAD-Project:master Oct 23, 2024
9 of 10 checks passed
@AcKoucher AcKoucher deleted the rsz-operation-state branch October 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AcKoucher @maliberty