ppl: escape backslashes in python tests #5961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Note that commits need to signed with |
maliberty
approved these changes
Oct 16, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: htfab <[email protected]>
auto-merge was automatically disabled
October 16, 2024 03:31
Head branch was pushed to by a user without write access
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Thanks! When I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 generates a SynthesisWarning for strings containing unescaped
\[or\]. This causes the test suite to fail, and indirectly blocks building .deb packages for Ubuntu 24.04 (which comes with Python 3.12 as the default).