gui: if no_init is specified on commandline previous settings will not be loaded #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be loaded Signed-off-by: Peter Gadfort <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I'm not sure it is good to overload -no_init. Perhaps a separate -no_settings would be clearer? |
|
I'll add a new flag for this one. |
Signed-off-by: Peter Gadfort <[email protected]>
|
@maliberty done |
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way to pass in the
no_initinformation to the GUI on load to start the GUI in a clean state.If we dont want to bring in the commandline flag, I suggest we still have this capability since it would be useful when debugging GUI issues and dealing with sometimes corrupted settings files.