Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: remove click+wait forever trap in Timing Report #5925

Closed
wants to merge 3 commits into from
Closed

gui: remove click+wait forever trap in Timing Report #5925

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
758dd81
gui: remove click+wait forever trap in Timing Report
oharboe Oct 12, 2024
fda8dcf
gui: disable reading of number of timing paths to read
oharboe Oct 12, 2024
bf38301
Merge remote-tracking branch 'origin/master' into HEAD
oharboe Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/gui/src/timingWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,18 @@ void TimingWidget::readSettings(QSettings* settings)
{
settings->beginGroup(objectName());

// FIXME don't read count, this can introduce problems when
// switching between large and small designs. Clicking Timing Report
// Update for a large number of paths will freeze the GUI, effectively
// for large designs.
//
// A better approach would be to read the settings only when the
// the Timing Report won't be so slow as to lock the GUI, but
// it is unclear what heuristic could be used.
#if 0
settings_->setPathCount(
settings->value("path_count", settings_->getPathCount()).toInt());
#endif
settings_->setOnePathPerEndpoint(
settings->value("one_path_per_endpoint").toBool());
settings_->setExpandClock(
Expand Down
Loading