drt: nodes structure refactoring and elimination of getFlatIdx #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
bnmfw
changed the title
Merged
osamahammad21
requested changes
Oct 15, 2024
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
bnmfw
force-pushed
the
drt_nodes_vec_vec
branch
from
49bcd04 to
6cd5ef0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@osamahammad21 I'm running a ISPD and Secure Ci on this new version, but I strongly suspect they will pass, so this is ready for review |
osamahammad21
approved these changes
Dec 3, 2024
Signed-off-by: bernardo <[email protected]>
bnmfw
force-pushed
the
drt_nodes_vec_vec
branch
from
6cd5ef0 to
3f22116
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes structure change
The
nodesvector has been refactored to be a vector of vectors index by the old "nested id". This allowed for the elimination of thegetFlatIdx()function, as now the indexing for nodes is always done through both idx.I benchmarked this changed and it seems to either not impact performance and improve memory consumption in some cases.
This change impacts various parts of the code as the structure is present in most of the functions that work with Access Patterns.
getEdgeCost refactoring
This PR also contains some minor refactoring on getEdgeCost (both implementations).
The refactoring that does not have to do with the nodes restructuring are: