drt: genPatterns_commit refactoring #5872
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2624,6 +2624,37 @@ int FlexPA::getEdgeCost( | |||||
| return edge_cost; | ||||||
| } | ||||||
|
|
||||||
| std::vector<int> FlexPA::extractAccessPatternFromNodes( | ||||||
| const std::vector<FlexDPNode>& nodes, | ||||||
| const std::vector<std::pair<frMPin*, frInstTerm*>>& pins, | ||||||
| std::set<std::pair<int, int>>& used_access_points, | ||||||
| const int max_access_point_size) | ||||||
| { | ||||||
| std::vector<int> access_pattern(pins.size(), -1); | ||||||
|
|
||||||
| const int source_node_idx = getFlatIdx(-1, 0, max_access_point_size); | ||||||
| const int drain_node_idx = getFlatIdx(pins.size(), 0, max_access_point_size); | ||||||
| auto drain_node = &(nodes[drain_node_idx]); | ||||||
|
There was a problem hiding this comment.
Suggested change
use const reference to the object instead of pointer. |
||||||
| int curr_node_idx = drain_node->getPrevNodeIdx(); | ||||||
|
Comment on lines
+2636
to
+2638
There was a problem hiding this comment. Does "drain" have a special meeting here? I the opposite of source is usually "sink" in these contexts There was a problem hiding this comment. I guess sink is the correct word in this context. |
||||||
|
|
||||||
| while (curr_node_idx != source_node_idx) { | ||||||
| if (curr_node_idx == -1) { | ||||||
| logger_->error(DRT, 90, "Valid access pattern not found."); | ||||||
| } | ||||||
|
|
||||||
| auto curr_node = &(nodes[curr_node_idx]); | ||||||
|
|
||||||
|
|
||||||
| int curr_pin_idx, curr_acc_point_idx; | ||||||
| getNestedIdx( | ||||||
| curr_node_idx, curr_pin_idx, curr_acc_point_idx, max_access_point_size); | ||||||
| access_pattern[curr_pin_idx] = curr_acc_point_idx; | ||||||
| used_access_points.insert({curr_pin_idx, curr_acc_point_idx}); | ||||||
|
|
||||||
| curr_node_idx = curr_node->getPrevNodeIdx(); | ||||||
| } | ||||||
| return access_pattern; | ||||||
| } | ||||||
|
|
||||||
| bool FlexPA::genPatterns_commit( | ||||||
| const std::vector<FlexDPNode>& nodes, | ||||||
| const std::vector<std::pair<frMPin*, frInstTerm*>>& pins, | ||||||
|
|
@@ -2634,139 +2665,113 @@ bool FlexPA::genPatterns_commit( | |||||
| const int curr_unique_inst_idx, | ||||||
| const int max_access_point_size) | ||||||
| { | ||||||
| std::vector<int> access_pattern = extractAccessPatternFromNodes( | ||||||
| nodes, pins, used_access_points, max_access_point_size); | ||||||
| // not a new access pattern | ||||||
| if (inst_access_patterns.find(access_pattern) != inst_access_patterns.end()) { | ||||||
| return false; | ||||||
| } | ||||||
|
|
||||||
| inst_access_patterns.insert(access_pattern); | ||||||
| // create new access pattern and push to uniqueInstances | ||||||
| auto pin_access_pattern = std::make_unique<FlexPinAccessPattern>(); | ||||||
| std::map<frMPin*, frAccessPoint*> pin_to_access_point; | ||||||
| // check DRC for the whole pattern | ||||||
| std::vector<std::pair<frConnFig*, frBlockObject*>> objs; | ||||||
| std::vector<std::unique_ptr<frVia>> temp_vias; | ||||||
| frInst* target_obj = nullptr; | ||||||
| for (int pin_idx = 0; pin_idx < (int) pins.size(); pin_idx++) { | ||||||
| auto acc_point_idx = access_pattern[pin_idx]; | ||||||
| auto& [pin, inst_term] = pins[pin_idx]; | ||||||
| auto inst = inst_term->getInst(); | ||||||
| target_obj = inst; | ||||||
| const int pin_access_idx = unique_insts_.getPAIndex(inst); | ||||||
| const auto pa = pin->getPinAccess(pin_access_idx); | ||||||
| const auto access_point = pa->getAccessPoint(acc_point_idx); | ||||||
| pin_to_access_point[pin] = access_point; | ||||||
|
|
||||||
| // add objs | ||||||
| std::unique_ptr<frVia> via; | ||||||
| if (access_point->hasAccess(frDirEnum::U)) { | ||||||
| via = std::make_unique<frVia>(access_point->getViaDef()); | ||||||
| auto rvia = via.get(); | ||||||
| temp_vias.push_back(std::move(via)); | ||||||
|
|
||||||
| dbTransform xform = inst->getUpdatedXform(true); | ||||||
| Point pt(access_point->getPoint()); | ||||||
| xform.apply(pt); | ||||||
| rvia->setOrigin(pt); | ||||||
| if (inst_term->hasNet()) { | ||||||
| objs.emplace_back(rvia, inst_term->getNet()); | ||||||
| } else { | ||||||
| objs.emplace_back(rvia, inst_term); | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| frAccessPoint* leftAP = nullptr; | ||||||
| frAccessPoint* rightAP = nullptr; | ||||||
| frCoord leftPt = std::numeric_limits<frCoord>::max(); | ||||||
| frCoord rightPt = std::numeric_limits<frCoord>::min(); | ||||||
|
Comment on lines
+2712
to
+2715
There was a problem hiding this comment. why the renaming? this is not the followed style. |
||||||
|
|
||||||
| const auto& [pin, inst_term] = pins[0]; | ||||||
| const auto inst = inst_term->getInst(); | ||||||
| for (auto& inst_term : inst->getInstTerms()) { | ||||||
| if (isSkipInstTerm(inst_term.get())) { | ||||||
| continue; | ||||||
| } | ||||||
| uint64_t n_no_ap_pins = 0; | ||||||
| for (auto& pin : inst_term->getTerm()->getPins()) { | ||||||
| if (pin_to_access_point.find(pin.get()) == pin_to_access_point.end()) { | ||||||
| n_no_ap_pins++; | ||||||
| pin_access_pattern->addAccessPoint(nullptr); | ||||||
| } else { | ||||||
| const auto& ap = pin_to_access_point[pin.get()]; | ||||||
| const Point tmpPt = ap->getPoint(); | ||||||
| if (tmpPt.x() < leftPt) { | ||||||
| leftAP = ap; | ||||||
| leftPt = tmpPt.x(); | ||||||
| } | ||||||
| if (tmpPt.x() > rightPt) { | ||||||
|
There was a problem hiding this comment. nope. Consider the first iteration. we need to set both; leftPt and rightPt, to tmpPt |
||||||
| rightAP = ap; | ||||||
| rightPt = tmpPt.x(); | ||||||
| } | ||||||
| pin_access_pattern->addAccessPoint(ap); | ||||||
| } | ||||||
| } | ||||||
| if (n_no_ap_pins == inst_term->getTerm()->getPins().size()) { | ||||||
| logger_->error(DRT, 91, "Pin does not have valid ap."); | ||||||
|
There was a problem hiding this comment. Capitalize AP. Also, can you add the term name to the print? |
||||||
| } | ||||||
| } | ||||||
| pin_access_pattern->setBoundaryAP(true, leftAP); | ||||||
| pin_access_pattern->setBoundaryAP(false, rightAP); | ||||||
|
|
||||||
| std::set<frBlockObject*> owners; | ||||||
| if (target_obj != nullptr | ||||||
| && genPatterns_gc({target_obj}, objs, Commit, &owners)) { | ||||||
| pin_access_pattern->updateCost(); | ||||||
| unique_inst_patterns_[curr_unique_inst_idx].push_back( | ||||||
| std::move(pin_access_pattern)); | ||||||
| // genPatterns_print(nodes, pins, max_access_point_size); | ||||||
| is_valid = true; | ||||||
| } else { | ||||||
| for (int idx_1 = 0; idx_1 < (int) pins.size(); idx_1++) { | ||||||
| auto idx_2 = access_pattern[idx_1]; | ||||||
| auto& [pin, inst_term] = pins[idx_1]; | ||||||
| if (inst_term->hasNet()) { | ||||||
| if (owners.find(inst_term->getNet()) != owners.end()) { | ||||||
| viol_access_points.insert(std::make_pair(idx_1, idx_2)); // idx ; | ||||||
| } | ||||||
| } else { | ||||||
| if (owners.find(inst_term) != owners.end()) { | ||||||
|
Comment on lines
+2762
to
+2766
There was a problem hiding this comment. I wonder if there's a more efficient way to do this because this will traverse |
||||||
| viol_access_points.insert(std::make_pair(idx_1, idx_2)); // idx ; | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| // new access pattern | ||||||
| return true; | ||||||
| } | ||||||
|
|
||||||
| void FlexPA::genPatternsPrintDebug( | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.